Fix the misleading rollback error messages, when failure occurs in include_tasks. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude_tasks. Because playbook failure can occur in include_tasks, variables that are used in those tasks have to be resolved, which doesn't happen after the failure has occurred (and the variables they depended on have changed) so we need to default the variables.
antoineserrano
requested review from
flfernandez,
antoineserrano and
dipiazzg
flfernandez
approved these changes
Feb 2, 2021
antoineserrano
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because playbook failure can occur in include_tasks, variables that are used in those tasks have to be resolved, which doesn't happen after the failure has occurred (and the variables they depended on have changed) so we need to default the variables.